feat(synthetics): support for private location resource#696
Merged
biscout42 merged 17 commits intoAug 6, 2024
Conversation
…g redefined: sweep`
… Optional, or Computed set..
Blocks of type "geo" are not expected here. Did you mean to define argument
biscout42
commented
Aug 5, 2024
biscout42
commented
Aug 5, 2024
tobio
reviewed
Aug 5, 2024
tobio
reviewed
Aug 6, 2024
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
LGTM, are you able to add an entry to CHANGELOG.md for this one and add the doc template/examples.
🎉
tobio
approved these changes
Aug 6, 2024
Member
There was a problem hiding this comment.
Should be named kibana_synthetics_private_location.md.tmpl. TBH I think I've done this exact thing for 9/10 new resources.
Member
|
Sorry @biscout42, I forgot to check if auto-merge was on. Are you able to fix the template filename in a follow-up? |
Contributor
Author
|
@tobio , sorry, will do. |
biscout42
added a commit
to biscout42/terraform-provider-elasticstack
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #610
TODOs: